search

NSLS-II / nslsii

NSLS-II related devices
BSD 3-Clause "New" or "Revised" License
10 stars 21 forks source link

.value --> .get() #102

Closed mrakitin closed 3 years ago

mrakitin commented 3 years ago

Observed during SRX deployment (Part 3) (https://github.com/NSLS-II-SRX/profile_collection/issues/10).

codecov-commenter commented 3 years ago

Codecov Report

Merging #102 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #102   +/-   ##
=======================================
  Coverage   57.17%   57.17%           
=======================================
  Files          13       13           
  Lines         892      892           
=======================================
  Hits          510      510           
  Misses        382      382

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 618ca49...d73df8f. Read the comment docs.

mrakitin commented 3 years ago

Thanks for reviewing this, @danielballan! Do you mind to check https://github.com/NSLS-II-HXN/hxntools/pull/19 as well? Identical updates.

mrakitin commented 3 years ago

@tacaswell, are you fine with the changes now? Thanks.