search

NSLS-II / nslsii

NSLS-II related devices
BSD 3-Clause "New" or "Revised" License
10 stars 21 forks source link

Sync useful changes with hxntools #104

Closed mrakitin closed 3 years ago

mrakitin commented 3 years ago

I haven't added the .value -> .get() changes as they are covered by #102. I ignored the old parts of code from hxntools which were fixed here already (e.g., #97).

Organizational note:

I think we should keep the xspress3-related code here in this repo, and remove it from hxntools, so we don't have to guess where to put future updates.

codecov-commenter commented 3 years ago

Codecov Report

Merging #104 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #104   +/-   ##
=======================================
  Coverage   57.17%   57.17%           
=======================================
  Files          13       13           
  Lines         892      892           
=======================================
  Hits          510      510           
  Misses        382      382

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 618ca49...f23d086. Read the comment docs.

mrakitin commented 3 years ago

Thanks Tom!