search

NSLS-II / nslsii

NSLS-II related devices
BSD 3-Clause "New" or "Revised" License
10 stars 21 forks source link

FIX: be forgiving of type instability in TwoButtonShutter status PV #116

Closed tacaswell closed 3 years ago

tacaswell commented 3 years ago

This needs to be on floor at every beamline by noon tomorrow.

https://github.com/bluesky/ophyd/pull/946 changed it so that the value passed to the callabck is the str version of the value not the integer.

This means that the conversion of int -> str we are doing in the callbacks of TwoButtonShutter are redundant and failing. This means that we will not ever mark the status object as done (and tend to fail with a miss leading error due to trying to set the shutter again on the way out of the RE).

This is a modified version of https://github.com/NSLS-II-ISS/profile_collection/pull/6 which is reportedly working at ISS

codecov-io commented 3 years ago

Codecov Report

Merging #116 (85fbfde) into master (26ff4a1) will increase coverage by 0.10%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
+ Coverage   58.10%   58.20%   +0.10%     
==========================================
  Files          13       13              
  Lines         938      938              
==========================================
+ Hits          545      546       +1     
+ Misses        393      392       -1
Impacted Files Coverage Δ
nslsii/tests/test_kafka_publisher.py 86.95% <0.00%> (-5.80%) :arrow_down:
nslsii/_version.py 44.80% <0.00%> (+1.79%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 26ff4a1...85fbfde. Read the comment docs.