search

NSLS-II / nslsii

NSLS-II related devices
BSD 3-Clause "New" or "Revised" License
10 stars 22 forks source link

ENH: add QuadEMV33 class with StatsPluginV33 #42

Closed mrakitin closed 5 years ago

mrakitin commented 5 years ago

This is used at XPD with the AD33 StatsPlugin: https://github.com/NSLS-II-XPD/profile_collection/pull/1.

mrakitin commented 5 years ago

I realized it may not be necessary with the profile-level fix: https://github.com/NSLS-II-XPD/profile_collection/pull/1/commits/983f7836e6a183c1ab4479b36fa1eb9c3915dc82.

tacaswell commented 5 years ago

sub-classing may be a better solution is both cases.

mrakitin commented 5 years ago

Good idea, @tacaswell! Do we still want it here in nslsii?

mrakitin commented 5 years ago

I updated the code so that the new QuadEMV33 is subclassed from QuadEM with the new StatsPluginV33 for the currents and sum_all. I'll update the XPD's profile accordingly.

mrakitin commented 5 years ago

Also, I replaced the confusing C with ADCpt as it's used in Ophyd.

mrakitin commented 5 years ago

Finally, added QuadEMPort to avoid having it in the BL profiles.

mrakitin commented 5 years ago

I tested this fix on xf28id2-ws6 with the source-installed code from this PR branch into collection-2018-3.2, works great after the recent fixes with https://github.com/NSLS-II-XPD/profile_collection/pull/1/files. I think we should merge it soon and tag a new version of nslsii, build it, generate a minor env files (2018-3.3), and push to all XPD's machines, since they requested to do it for the experiments.