search

NSLS-II / nslsii

NSLS-II related devices
BSD 3-Clause "New" or "Revised" License
10 stars 22 forks source link

add a collection of generic slit devices #53

Closed awalter-bnl closed 4 months ago

awalter-bnl commented 5 years ago

This PR is designed to add some generic slit devices based on ophyd.Devices (FourBladeSlits, ScanAndApertureBaffleSlits and FrontEndSlits). As these are common NSLS-II items we would prefer to have a common source for these, instead of the scattered large number we currently have.

These are based on what already exists on the floor, but are un-tested. I am opening the PR to get feedback on the overall structure of this. Tests will be added once the DAMA group decides how we should implement them (in particular the IOC's to test against).

codecov-io commented 5 years ago

Codecov Report

Merging #53 into master will decrease coverage by 17.6%. The diff coverage is 7.89%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #53       +/-   ##
===========================================
- Coverage   43.32%   25.72%   -17.61%     
===========================================
  Files          10       15        +5     
  Lines         584      797      +213     
===========================================
- Hits          253      205       -48     
- Misses        331      592      +261
Impacted Files Coverage Δ
nslsii/tests/motor_devices_test.py 14.28% <14.28%> (ø)
nslsii/motor_devices/slits.py 6.45% <6.45%> (ø)
nslsii/tests/test_ipynb.py 12.5% <0%> (-87.5%) :arrow_down:
nslsii/tests/temperature_controllers_test.py 33.33% <0%> (-66.67%) :arrow_down:
nslsii/temperature_controllers.py 26.53% <0%> (-65.31%) :arrow_down:
nslsii/common/ipynb/info.py 15% <0%> (-40%) :arrow_down:
nslsii/__init__.py 4.76% <0%> (-1.23%) :arrow_down:
nslsii/iocs/tests/test_epstwostate_ioc.py 15.74% <0%> (ø)
nslsii/tests/test_logutils.py 44.44% <0%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 56e1d9a...ba61152. Read the comment docs.

awalter-bnl commented 5 years ago

based on feedback regarding the lakeshore controller PR ( #54 ) I have converted the base class into a factory function for generating classes.

awalter-bnl commented 5 years ago

The errors are caused by a dependency on an unreleased version of Ophyd. I will resolve that as soon as we have a release.

awalter-bnl commented 5 years ago

@danielballan thanks

awalter-bnl commented 5 years ago

cycled the PR close/open to restart the tests.

awalter-bnl commented 4 years ago

am guessing that judging by the fact this hasn't been merged that it is no longer required. closing it out, feel free to resurrect it if it is needed in the future.

awalter-bnl commented 4 years ago

reopening at the request of @mrakitin