codecov-io
commented
5 years ago Codecov Report
Merging #54 into master will decrease coverage by
16.85%. The diff coverage is11.9%.
@@ Coverage Diff @@
## master #54 +/- ##
===========================================
- Coverage 43.32% 26.46% -16.86%
===========================================
Files 10 8 -2
Lines 584 631 +47
===========================================
- Hits 253 167 -86
- Misses 331 464 +133| Impacted Files | Coverage Δ | |
|---|---|---|
| nslsii/temperature_controllers/eurotherm.py | 26.53% <ø> (ø) |
|
| nslsii/tests/temperature_controllers_test.py | 5.55% <28.57%> (-94.45%) |
:arrow_down: |
| nslsii/temperature_controllers/lakeshore.py | 8.57% <8.57%> (ø) |
|
| nslsii/tests/test_ipynb.py | 12.5% <0%> (-87.5%) |
:arrow_down: |
| nslsii/common/ipynb/info.py | ||
| nslsii/common/ipynb/animation.py | ||
| nslsii/common/ipynb/nbviewer.py | ||
| nslsii/common/ipynb/__init__.py | ||
| ... and 2 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 56e1d9a...1f01890. Read the comment docs.
awalter-bnl
This PR is designed to add a generic Lakeshore model 336 device based on
ophyd.Device. As these are standard NSLS-II items we would prefer to have a common source for these, instead of the scattered large number we currently have. I am yet to determine if we are using a pulbically available IOC, if it turns out we are I will instead move this device toophydinstead of this repo.These are based on what already exists on the floor, but are un-tested. I am opening the PR to get feedback on the overall structure of this. Tests will be added once the DAMA group decides how we should implement them (in particular the IOC's to test against).