search

NSLS-II / nslsii

NSLS-II related devices
BSD 3-Clause "New" or "Revised" License
10 stars 22 forks source link

FIX: Two critical fixes to Eurotherm #58

Open danielballan opened 5 years ago

danielballan commented 5 years ago

I used this against the caproto.ioc_examples.thermo_sim IOC for the tutorial and found a couple bugs.

codecov-io commented 5 years ago

Codecov Report

Merging #58 into master will increase coverage by 9.77%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
+ Coverage   42.46%   52.24%   +9.77%     
==========================================
  Files          10       11       +1     
  Lines         584      691     +107     
==========================================
+ Hits          248      361     +113     
+ Misses        336      330       -6
Impacted Files Coverage Δ
nslsii/temperature_controllers.py 93.75% <100%> (+1.91%) :arrow_up:
nslsii/iocs/tests/test_epstwostate_ioc.py 100% <0%> (ø)
nslsii/_version.py 44.4% <0%> (+1.8%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0ff403e...1ad4156. Read the comment docs.

awalter-bnl commented 5 years ago

we should solve the Travis error first

tacaswell commented 5 years ago

The failure looked like it was due to flake8 issues in code not touched by this PR, power-cycled to re-run against current master to see if that just fixes it.