NSLS-II / nslsii

NSLS-II related devices

BSD 3-Clause "New" or "Revised" License

10 stars 22 forks source link

WIP: moving the xpress3 device and components from hxntools #61

Closed awalter-bnl closed 4 years ago

awalter-bnl commented 5 years ago

I am opening this PR to copy over the changes that have been made to hxntools version of the xpress3 detector. As all of the existing implementations reference the version in hxntools instead of this one.

This will allow us to remove a dependency on hxntools from multiple beamlines without causing any operational downtime (as it will be a simple change in the import location and nothing else.

codecov-io commented 5 years ago

Codecov Report

Merging #61 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #61   +/-   ##
=======================================
  Coverage   52.16%   52.16%           
=======================================
  Files          11       11           
  Lines         692      692           
=======================================
  Hits          361      361           
  Misses        331      331

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bd076a7...7119546. Read the comment docs.

awalter-bnl commented 5 years ago

Adding the WIP to the name and a Do Not Merge tag as this needs more discussion before proceeding

awalter-bnl commented 4 years ago

due to the lack of discussion I am guessing this is not required/wanted. am closing this out.

mrakitin commented 4 years ago

I think this PR will help to generalize the approach to fly scans used at SRX, HXN, ... Let's keep it open.

mrakitin commented 4 years ago

This PR is superseded by https://github.com/NSLS-II/nslsii/pull/79.