search

NSLS-II / nslsii

NSLS-II related devices
BSD 3-Clause "New" or "Revised" License
11 stars 23 forks source link

BLD: pin attrs>=17.4.0 #69

Closed ke-zhang-rd closed 5 years ago

ke-zhang-rd commented 5 years ago

For error report below https://travis-ci.com/NSLS-II/nslsii/jobs/205765574

Solution are based on discussion here https://github.com/Julian/jsonschema/issues/449

codecov-io commented 5 years ago

Codecov Report

Merging #69 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #69   +/-   ##
=======================================
  Coverage   52.16%   52.16%           
=======================================
  Files          11       11           
  Lines         692      692           
=======================================
  Hits          361      361           
  Misses        331      331

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bd076a7...6438ac3. Read the comment docs.

danielballan commented 5 years ago

Wouldn't the fix in databroker have propagated here and been sufficient? Unlike databroker, nslsii has no direct dependency on attrs.