NSLS-II / nslsii

NSLS-II related devices
BSD 3-Clause "New" or "Revised" License
10 stars 22 forks source link

Update pv suffixes #71

Closed awalter-bnl closed 4 years ago

awalter-bnl commented 4 years ago

The IOC for the Eurotherm was updated some time ago but the ophyd object for it was not updated to mirror the new PV suffixes.

codecov-io commented 4 years ago

Codecov Report

Merging #71 into master will decrease coverage by 0.06%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
- Coverage   52.16%   52.09%   -0.07%     
==========================================
  Files          11       10       -1     
  Lines         692      691       -1     
==========================================
- Hits          361      360       -1     
  Misses        331      331
Impacted Files Coverage Δ
nslsii/tests/temperature_controllers_test.py 100% <ø> (ø) :arrow_up:
nslsii/temperature_controllers.py 91.83% <100%> (ø) :arrow_up:
nslsii/common/__init__.py

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 251ad7f...b3ef408. Read the comment docs.

mrakitin commented 4 years ago

Looks good, but the tests failed:

self = <[TimeoutError("Failed to connect to thermo:T-SP") raised in repr()] EpicsSignal object at 0x7f09471c0748>

Is it something to be fixed in the tests as well?

awalter-bnl commented 4 years ago

Ah good catch @mrakitin. I will have to put in a PR to caproto to update the simulated Eurotherm IOC with the new PR’s I will do that on Monday

awalter-bnl commented 4 years ago

attn @mrakitin A PR to update the caproto simulated IOC has been placed into caproto/caproto PR#501 here

This should resolve the test failures we are observing by updating to the new PV suffixes.

awalter-bnl commented 4 years ago

@mrakitin I now have the tests passing. can you take another look?