mrakitin commented 4 years ago

This update is to have the code for xspress3 synched with hxntools.

An extra update is to correct the import of DeviceStatus to work properly with ophyd 1.4.x.

codecov-io commented 4 years ago

Codecov Report

Merging #79 into master will increase coverage by 4.14%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
+ Coverage   52.34%   56.48%   +4.14%     
==========================================
  Files          13       13              
  Lines         724      809      +85     
==========================================
+ Hits          379      457      +78     
- Misses        345      352       +7

Impacted Files	Coverage Δ
nslsii/common/ipynb/logutils.py	`92.85% <0%> (-7.15%)`	:arrow_down:
nslsii/tests/test_logutils.py	`100% <0%> (ø)`	:arrow_up:
nslsii/temperature_controllers.py	`93.87% <0%> (+2.04%)`	:arrow_up:
nslsii/__init__.py	`24.71% <0%> (+17.94%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ee11542...69a5dcf. Read the comment docs.

mrakitin commented 4 years ago

@tacaswell, bump.

tacaswell commented 4 years ago

I'm not sure I can reason through this without having a device to play with.

mrakitin commented 4 years ago

Thanks @tacaswell! I tested this code on the ISS' xspress3 detector, and it worked fine. See https://github.com/NSLS-II-ISS/profile_collection/pull/40/files#diff-b86b71b8ada3f1c237f9c32061df2d92 for details.

NSLS-II / nslsii

Sync xspress3 code with hxntools #79

Codecov Report