search

NSLS-II / nslsii

NSLS-II related devices
BSD 3-Clause "New" or "Revised" License
10 stars 22 forks source link

added transform to fix rsoxs descriptor #83

Open gwbischof opened 4 years ago

gwbischof commented 4 years ago

I tested a bit with real rsoxs data.. until i ran out of RAM.

gwbischof commented 4 years ago

Fixes #82

gwbischof commented 4 years ago

based on the PR: https://github.com/bluesky/databroker/pull/474 I thought I was going to have to swap the x,y dims. But i was getting shape errors when I did that.

codecov-io commented 4 years ago

Codecov Report

Merging #83 into master will decrease coverage by 2.47%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
- Coverage   55.87%   53.39%   -2.48%     
==========================================
  Files          13       13              
  Lines         809      809              
==========================================
- Hits          452      432      -20     
- Misses        357      377      +20
Impacted Files Coverage Δ
nslsii/tests/temperature_controllers_test.py 66.66% <0.00%> (-33.34%) :arrow_down:
nslsii/temperature_controllers.py 63.26% <0.00%> (-30.62%) :arrow_down:
nslsii/_version.py 44.40% <0.00%> (+1.80%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b1cbe23...aec21d0. Read the comment docs.

gwbischof commented 4 years ago

I made the helper functions, because I suspect that other descriptor transforms will use them too