NSLS-II / nslsii

NSLS-II related devices
BSD 3-Clause "New" or "Revised" License
11 stars 23 forks source link

use appdirs to determine default logging directory #88

Closed jklynch closed 4 years ago

jklynch commented 4 years ago

The default logging directory will be determined by appdirs.user_log_dir(). Environment variables BLUESKY_LOG_FILE and BLUESKY_IPYTHON_LOG_FILE can still be used to override the default.

This PR addresses issue #84.

codecov-commenter commented 4 years ago

Codecov Report

Merging #88 into master will increase coverage by 3.70%. The diff coverage is 96.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage   53.11%   56.81%   +3.70%     
==========================================
  Files          13       13              
  Lines         819      880      +61     
==========================================
+ Hits          435      500      +65     
+ Misses        384      380       -4     
Impacted Files Coverage Δ
nslsii/common/ipynb/logutils.py 92.85% <ø> (ø)
nslsii/__init__.py 28.72% <81.25%> (+3.72%) :arrow_up:
nslsii/iocs/tests/test_epstwostate_ioc.py 100.00% <100.00%> (ø)
nslsii/tests/temperature_controllers_test.py 66.66% <100.00%> (ø)
nslsii/tests/test_logutils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 67a9104...10a683b. Read the comment docs.

jklynch commented 4 years ago

Why is test_Eurotherm failing?

jklynch commented 4 years ago

the only test failure is test_Eurotherm, still

danielballan commented 4 years ago

Pushed a commit to mark the problematic Eurotherm test that we are consistently ignoring as a "known failure" so that CI red/green is meaningful again.

danielballan commented 4 years ago

Because of the consistent Eurotherm failures we didn't notice flake8 errors. Added another commit fixing those....

danielballan commented 4 years ago

Green!