search

NSLS-II / nslsii

NSLS-II related devices
BSD 3-Clause "New" or "Revised" License
10 stars 21 forks source link

create default log directory #89

Closed jklynch closed 4 years ago

jklynch commented 4 years ago

Closes #84.

This PR changes the behavior of the two logging configuration functions. Previously the default log directory would not be created and an exception was raised if it did not exist. Now if that directory does not exist it will be created.

Existing tests have been updated. New tests have been added.

codecov-commenter commented 4 years ago

Codecov Report

Merging #89 into master will increase coverage by 1.86%. The diff coverage is 95.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
+ Coverage   56.25%   58.11%   +1.86%     
==========================================
  Files          13       12       -1     
  Lines         880      912      +32     
==========================================
+ Hits          495      530      +35     
+ Misses        385      382       -3
Impacted Files Coverage Δ
nslsii/tests/test_logutils.py 98.46% <93.93%> (-1.54%) :arrow_down:
nslsii/__init__.py 30.92% <100.00%> (+2.20%) :arrow_up:
nslsii/common/__init__.py
nslsii/_version.py 44.40% <0.00%> (+1.80%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8c5ccb2...686ab69. Read the comment docs.