search

NSLS-II / nslsii

NSLS-II related devices
BSD 3-Clause "New" or "Revised" License
10 stars 21 forks source link

Add a control to Xspress3Channel to enable/disable ROIs 5 through 16 #95

Closed bruceravel closed 2 years ago

bruceravel commented 3 years ago

This adds an attribute to the Xspress3Channel class to toggle on ROIs 5 through 16. The IOC seems to disable all ROIs by default. The CSS screen provides controls for enabling these, but save/restore for the standard IOC does not seem to remember this change. I want to use the high numbered ROIs, so I need access to these PVs when I instantiate an instance of this class.

I think this changes costs very little and provides a sensible interface to a PV to which I need a sensible interface.

bruceravel commented 3 years ago

(See #94)

codecov-commenter commented 3 years ago

Codecov Report

Merging #95 into master will increase coverage by 0.56%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
+ Coverage   56.61%   57.17%   +0.56%     
==========================================
  Files          13       13              
  Lines         892      892              
==========================================
+ Hits          505      510       +5     
+ Misses        387      382       -5
Impacted Files Coverage Δ
nslsii/_version.py 44.80% <0.00%> (+1.79%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 18c0632...75a365e. Read the comment docs.

bruceravel commented 3 years ago

I don't know the answers to your questions. What I do know if that the high numbered ROIs started disabled and that this is the PV that enables them. At least on the instance at BMM. Hmmm... occurs to me that the Centos box that came with the new Xspress3 is running a fairly old version of AD. I suppose it's possible that this has changed between then and now. I know that Quantum is not yet supporting/distributing the extensive work out of GSECARS, which seems awfully lazy.

lcdesilva commented 3 years ago

From what I see, this PV is not available in the EPICS IOC version from APS. I will have to take a closer look to confirm. For the Quantum IOC version, the PV for enabling 1-4 is different from 5-16. Just wanted to make that latter note.

jklynch commented 2 years ago

@mrakitin there should be no conflict with the new xspress3 code, it is entirely separate