NSLS-II / olog

Python client to the Olog
BSD 3-Clause "New" or "Revised" License
2 stars 4 forks source link

DOC: separate olog user env var from system var $USER #1

Closed mrakitin closed 6 years ago

mrakitin commented 6 years ago

I think it's worth to separate olog user and env variable $USER, which do not have to match. So, I'm suggesting to have OLOG_USER and OLOG_PASSWORD to avoid ambiguity.

danielballan commented 6 years ago

Good call. This is in fact a typo. See .env.example, which names them using the OLOG_ prefix.

mrakitin commented 6 years ago

Great, yes, I saw the code has correct names, e.g. https://github.com/NSLS-II/pyolog2/blob/c38f8d6bcc05d008746b5f476b47c8cfc9f15d26/test_olog.py#L24