search

NSLS-II / olog

Python client to the Olog
BSD 3-Clause "New" or "Revised" License
2 stars 4 forks source link

circleci? #20

Closed ke-zhang-rd closed 4 years ago

ke-zhang-rd commented 4 years ago

circleci is activated for this repo's master branch but lacking config.yml. Should be deactivate or config it? I lean to deactivate it since we already have Travis and I didn't see big differences.

ke-zhang-rd commented 4 years ago

CircleCi is turn off. CI needs is covered by Trivis

danielballan commented 4 years ago

Echoing here on a public channel a comment I made on a private one:

I think this is left over from experiments by @mrakitin involving CircleCI and containers. I am not opposed to continuing those experiments in the future, but until we have a container for the Olog ES server, we can proceed with just TravisCI and VCR.

Thanks for cleaning this up, @ke-zhang-rd. Please comment if I have misunderstood the state of play, @mrakitin.

mrakitin commented 4 years ago

I have no memory of enabling CircleCI, and I am not a big fan of it anyway. I think having TravisCI for now is enough. As @danielballan mentioned, it would be great to have a docker image with the server (cc @shroffk), so that we can try to use it for tests, but it can easily be done in TravisCI. A good candidate for the CI platforms is Azure Pipelines, which we can enable later if we need to.