search

NSLS-II / olog

Python client to the Olog
BSD 3-Clause "New" or "Revised" License
2 stars 4 forks source link

Pkg infrastructure #21

Closed ke-zhang-rd closed 4 years ago

ke-zhang-rd commented 4 years ago

For issue #19 Also add multiple pkg/CI tools config file

codecov-commenter commented 4 years ago

Codecov Report

Merging #21 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master       #21    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files            2         3     +1     
  Lines          267       163   -104     
==========================================
- Hits           267       163   -104
Impacted Files Coverage Δ
olog/__init__.py 100.00% <100.00%> (ø)
olog/httpx_client.py 100.00% <100.00%> (ø)
olog/util.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ed0d321...f5206de. Read the comment docs.

stuartcampbell commented 4 years ago

I can see the benefit of not using pyolog for the name so we can draw a line under the confusing versioning and different projects and start 'clean'. To me olog seems the most obvious (and is free on pypi) - just my two cents.

danielballan commented 4 years ago

This seems mostly ready. One last small thing:

Using git grep pyolog2 I discovered that cassettes/test_post_attachment has the string pyolog2 in it because the README.md was used as a test attachment file. I think this is not an ideal choice as a test file because, of course, the README.md file will evolve independently over time. Instead I would propose creating a special file for this purposes, example_attachment.txt or something.