NSLS-II / olog

Python client to the Olog
BSD 3-Clause "New" or "Revised" License
2 stars 4 forks source link

Should the argument to get_logs be keyword-only? #23

Closed danielballan closed 4 years ago

danielballan commented 4 years ago

This signature

https://github.com/NSLS-II/olog/blob/a04f1055df76c3ce62f84e31eea37180bab33b67/olog/httpx_client.py#L95-L97

may be a good first for keyword-only arguments because

ke-zhang-rd commented 4 years ago

sounds good

ke-zhang-rd commented 4 years ago

closed by #25