Open ambarb opened 3 years ago
probably deleted the function that is copied into skbeam.
@tankonst approach to error bars in skbeam should be added to
pyCHX.Two_Time_Correlation_Functions.get_one_time_from_two_time
we will delete
pyCHX.Two_Time_Correlation_Functions.get_one_time_from_two_time_old
@ambarb delete and get tests @tankonst error bars
Note here to remember that this is broken but fixed and enhanced in
scikit-beam
+ better testing. https://github.com/scikit-beam/scikit-beam/pull/566 https://github.com/scikit-beam/scikit-beam/pull/571However, equivalent (and with more options) exists already in
pyCHX.Two_Time_Correlation_Functions.get_one_time_from_two_time
pyCHX.Two_Time_Correlation_Functions.get_one_time_from_two_time_old
We need to just consider adding error bar functionality as done by @tankonst https://github.com/scikit-beam/scikit-beam/pull/571
any objections to error bars? discussion on returned data format?