NSLS-II / pyCHX

chx_analysis_codes
BSD 3-Clause "New" or "Revised" License
5 stars 6 forks source link

[v2][_commonspeckle] for xpcs_timepixel.py is there anything we can learn from this or should we delete #40

Open ambarb opened 3 years ago

ambarb commented 3 years ago

@afluerasu said this was just a test of the detector to see what worked and that this is not used at CHX

Is there anything we can learn from this module to make the others more generic?

Should we set aside this module for future implementations of the LBNL TimePix for soft x-rays?

ambarb commented 3 years ago

not deleting because using timepix for quantum.

@danielballan suggest to find the day this file was created and compare to chx_correlationp.py or chx_correlationc.py to see if we just need to get IO and put somewhere so we can interface.

danielballan commented 3 years ago

This is a bigger mess than I had anticipated. The copy-pasting was not a one-time event, but rather a habit that spanned over multiple years. There are no short-cuts here other than line-by-line comparing each function.

danielballan commented 3 years ago

(I had thought this split was the result of a one-time rush to make a specific experiment work that just never got cleaned up.)