This is a place holder to address lines of code that were commented out of V1. Are these lines used as on-the-fly configurations or can they be deleted?
SO far, V2 commented out can be differentiated from V1 commented out because the line will end with #common. For example in v2._commonspeckle.chx_xpcs_xsvs_jupyter_V1:
1 #from pyCHX.v2._commonspeckle.chx_packages import * #common
2 from pyCHX.v2._commonspeckle.chx_libs import markers, colors #common #TODO all other instances import with ()
3 #from pyCHX.chx_generic_functions import get_short_long_labels_from_qval_dict
4 #RUN_GUI = False
5 #from pyCHX.chx_libs import markers
6 import pandas as pds
7
Lines 3, 4 & 5 were commit and released before V2 began.
Seems can delete line 5
Don't know about lines 3 & 4
Line 1 was commented out after import from V2 was set up.
First, we need to generate a report so someone knowledgeable can review the code. @ambarb will do that below, so assigning to her for now.
This is a place holder to address lines of code that were commented out of V1. Are these lines used as on-the-fly configurations or can they be deleted?
SO far, V2 commented out can be differentiated from V1 commented out because the line will end with
#common. For example inv2._commonspeckle.chx_xpcs_xsvs_jupyter_V1:Lines 3, 4 & 5were commit and released before V2 began.line 5lines 3 & 4Line 1was commented out after import from V2 was set up.First, we need to generate a report so someone knowledgeable can review the code. @ambarb will do that below, so assigning to her for now.