search

NSLS-II / pyCHX

chx_analysis_codes
BSD 3-Clause "New" or "Revised" License
5 stars 6 forks source link

[V1] likely broken import of XPCS_XSVS_SAXS_Multi_2017_V4 - obsolete? can delete? #45

Open ambarb opened 3 years ago

ambarb commented 3 years ago

https://github.com/NSLS-II/pyCHX/blob/6e991bb1eb06d8fe1bc8f684ebfcec581ee57aba/pyCHX/XPCS_XSVS_SAXS_Multi_2017_V4.py#L5

Show it relies on a function from a package that does not exist. should import as

from pyCHX.chx_xpcs_xsvs_jupyter_V1 import run_xpcs_xsvs_single

I did not discover in V1 (pyCHX), but found this to be the case in the default copies of V2 (pyCHX.v2._commonspeckle).

Is this module XPCS_XSVS_SAXS_Multi_2017_V4 still requiring use or can it be deleted because it is obsolete? If still required, then we can discuss further

ambarb commented 3 years ago

@afluerasu believes this is obsolete but will check