Closed ambarb closed 4 years ago
maybe this is easier to review
@danielballan i am a little confused about this PR. it says there are conflicts, but when I look at the files changed view, nothing indicdates there is a conflict. I've seen that in the past conflict show up on this page https://github.com/NSLS-II/pyCHX/pull/46/files. Can you recommend another tool for me to sort this out?
Confirmed locally that this does not rebase cleanly on master
. I can help on a call if you want, or just do it.
I should learn. can I schedule time tomorrow? otherwise, early next week is ok to.
there are a lot of files here but the only one @afluerasu will care about is: pyCHX/XPCS_XSVS_SAXS_Multi_2017_V4.py --> which may be obsolete as discussed
I just undid the erroneous edit i made. I didn't figure out how to undo the "edit" using git. The file is the same if you look by eye, it just wasn't worth the single line mistake i made, but it matches what you have installed at CHX.
Notebooks still indicates all v2._commonspeckle modules import at CSX.
@danielballan thanks for the rebase tutorial. it was really good.
There was something funny after all the conflicts resolved when i diff'ed between my local files and the remote files on this fork's branch, so I was scared to force the push. i instead pulled the remote, fixed a few small things, and then finally pushed my local copy to the remote. All looks good. May be some circular changes but I think everything is ok.
Confirmed this PR only touches files in
pyCHX/v2/_commonspeckle
Now the following modules should import in any conda environment (does not require
Broker.named = 'chx'
)The following modules have not been configured/tested. These will be addressed later.
@tankonst FYI so if you want to try before PR is merged to the main branch of pyCHX.