search

NSLS-II / pyCHX

chx_analysis_codes
BSD 3-Clause "New" or "Revised" License
5 stars 6 forks source link

handlers seems to have no active function, delete module?? #48

Open ambarb opened 3 years ago

ambarb commented 3 years ago

Noticed a comment: https://github.com/NSLS-II/pyCHX/blob/2ecdacf0dd8496dd8e90bb4975273b59e1d08e26/pyCHX/v2/_commonspeckle/chx_handlers.py#L18-L21

This basically applies to the entire module. We should decide what to do on this.

@danielballan can you comment on this usage at SDCC versus CHX servers I am voting for delete from _commonspeckle

ambarb commented 3 years ago

current usage is in V1 package


(base) [abarbour@box64-3 ~/Repos/pyCHX/pyCHX ✓ ] $ grep -R use_pims
chx_packages.py:from pyCHX.chx_handlers import use_pims, use_dask
chx_packages.py:use_pims(db)  #use pims for importing eiger data, register_handler 'AD_EIGER2' and 'AD_EIGER'

(base) [abarbour@box64-3 ~/Repos/pyCHX/pyCHX ✓ ] $ grep -R use_dask
chx_packages.py:from pyCHX.chx_handlers import use_pims, use_dask

maybe use_pims() is used? it is called here: https://github.com/NSLS-II/pyCHX/blob/2ecdacf0dd8496dd8e90bb4975273b59e1d08e26/pyCHX/chx_packages.py#L1-L16

ambarb commented 3 years ago

discussed with @danielballan @tankonst and we will delete handlers from _commonspeckle since handlers appears to be associated with io.

it may be required for _futurepyCHX --> pyCHX