test and delete tqdm patch

NSLS-II / pyCHX

chx_analysis_codes

BSD 3-Clause "New" or "Revised" License

5 stars 6 forks source link

test and delete tqdm patch #50

Open ambarb opened 3 years ago

ambarb commented 3 years ago

https://github.com/NSLS-II/pyCHX/blob/2ecdacf0dd8496dd8e90bb4975273b59e1d08e26/pyCHX/v2/_commonspeckle/chx_correlation.py#L49-L55

[ ] remove patch
[ ] global fix to imports (see below)
[ ] use in _commonspeckle.chx_speckle or merge with _commonspeckle.chx_specklecp

ambarb commented 3 years ago

are other import methods are used without patch in all modules. both use tqdm and there are a mixture of implementations.

from tqdm import tqdm in chx_libs and then import chx_libs
from tqdm import tqdm

for the final implementation, we should choose least dependancies unless we end up with a very long list of standard imports that are the same for several modules.