NSLS-II / pyCHX

chx_analysis_codes
BSD 3-Clause "New" or "Revised" License
5 stars 6 forks source link

multiple instances of function/variable `ps` for different purposes #60

Open ambarb opened 3 years ago

ambarb commented 3 years ago

"ps" is used for different things in the code base.

Instance 1

https://github.com/NSLS-II/pyCHX/blob/6e991bb1eb06d8fe1bc8f684ebfcec581ee57aba/pyCHX/chx_generic_functions.py#L996-L1006

There are notes in code to @mrakitin .
Is this used in analysis to not have to fit to find the center of a peak? It seems it was associated with a Bluesky profile file. Is this new one used in bluesky? What does "ps" mean in this context? peak stats? peak scaling?

Instance 2

show_g12q_aged_g2() https://github.com/NSLS-II/pyCHX/blob/6e991bb1eb06d8fe1bc8f684ebfcec581ee57aba/pyCHX/Two_Time_Correlation_Function.py#L599-L621

Instance(s) 3

in xpcs_timepixelmodule in 2 functions https://github.com/NSLS-II/pyCHX/blob/6e991bb1eb06d8fe1bc8f684ebfcec581ee57aba/pyCHX/xpcs_timepixel.py#L25-L36 "ps" is photon statitisics? https://github.com/NSLS-II/pyCHX/blob/6e991bb1eb06d8fe1bc8f684ebfcec581ee57aba/pyCHX/xpcs_timepixel.py#L50-L72 "ps" is photon positions

Instance 4

in speckle* modules for fit_xsvs1. "ps" is Poisson distribution

mrakitin commented 3 years ago

Regarding Andi's question - I believe it stands for "peak stats". I recognize some of my code, but not everything. It looks like it is an extended version of the one from BEC.

-------- Original message -------- From: Andi Barbour notifications@github.com Date: 2/9/21 18:05 (GMT-05:00) To: NSLS-II/pyCHX pyCHX@noreply.github.com Cc: "Rakitin, Maksim" mrakitin@bnl.gov, Assign assign@noreply.github.com Subject: [NSLS-II/pyCHX] when / how is ps used (#60)

"ps" is used for different things in the code base.

Instance 1

https://github.com/NSLS-II/pyCHX/blob/6e991bb1eb06d8fe1bc8f684ebfcec581ee57aba/pyCHX/chx_generic_functions.py#L996-L1006

There are notes in code to @mrakitinhttps://github.com/mrakitin . Is this used in analysis to not have to fit to find the center of a peak? It seems it was associated with a Bluesky profile file. Is this new one used in bluesky? What does "ps" mean in this context? peak stats? peak scaling?

Instance 2

show_g12q_aged_g2() https://github.com/NSLS-II/pyCHX/blob/6e991bb1eb06d8fe1bc8f684ebfcec581ee57aba/pyCHX/Two_Time_Correlation_Function.py#L599-L621

Instance(s) 3

in xpcs_timepixelmodule in 2 functions https://github.com/NSLS-II/pyCHX/blob/6e991bb1eb06d8fe1bc8f684ebfcec581ee57aba/pyCHX/xpcs_timepixel.py#L25-L36 "ps" is photon statitisics? https://github.com/NSLS-II/pyCHX/blob/6e991bb1eb06d8fe1bc8f684ebfcec581ee57aba/pyCHX/xpcs_timepixel.py#L50-L72 "ps" is photon positions

Instance 4

in speckle* modules for fit_xsvs1. "ps" is Poisson distribution

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/NSLS-II/pyCHX/issues/60, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADEY4WFJGR3YGHPPWHIQQCDS6G5T3ANCNFSM4XL4BW4A.