search

NSLS-II / pyCHX

chx_analysis_codes
BSD 3-Clause "New" or "Revised" License
5 stars 6 forks source link

Address skimage renaming of 'circle' to 'disk' #72

Closed danielballan closed 2 years ago

danielballan commented 2 years ago

In skimage 0.19.0, the deprecated alias circle was removed. It has to be updated to disk in many places:

$ git grep skimage.draw
pyCHX/chx_generic_functions.py:from skimage.draw import line_aa, line, polygon, ellipse, circle
pyCHX/chx_generic_functions.py:    from skimage.draw import line_aa, line, polygon, circle    
pyCHX/chx_generic_functions.py:    from skimage.draw import line_aa, line, polygon, circle    
pyCHX/chx_generic_functions.py:    from skimage.draw import  polygon
pyCHX/chx_generic_functions.py:    from skimage.draw import line_aa, line, polygon, circle
pyCHX/chx_generic_functions.py:    from skimage.draw import line_aa, line, polygon, circle
pyCHX/chx_generic_functions.py:        from skimage.draw import  circle    
pyCHX/chx_libs.py:from skimage.draw import line_aa, line, polygon, ellipse, circle
pyCHX/chx_packages.py:from skimage.draw import line_aa, line, polygon
pyCHX/v2/_commonspeckle/chx_generic_functions.py:from skimage.draw import line_aa, line, polygon, ellipse, circle
pyCHX/v2/_commonspeckle/chx_generic_functions.py:    from skimage.draw import line_aa, line, polygon, circle
pyCHX/v2/_commonspeckle/chx_generic_functions.py:    from skimage.draw import line_aa, line, polygon, circle
pyCHX/v2/_commonspeckle/chx_generic_functions.py:    from skimage.draw import polygon
pyCHX/v2/_commonspeckle/chx_generic_functions.py:    from skimage.draw import line_aa, line, polygon, circle
pyCHX/v2/_commonspeckle/chx_generic_functions.py:    from skimage.draw import line_aa, line, polygon, circle
pyCHX/v2/_commonspeckle/chx_generic_functions.py:        from skimage.draw import circle
pyCHX/v2/_commonspeckle/chx_libs.py:from skimage.draw import line_aa, line, polygon, ellipse, circle
pyCHX/v2/_futurepyCHX/chx_generic_functions.py:from skimage.draw import line_aa, line, polygon, ellipse, circle
pyCHX/v2/_futurepyCHX/chx_generic_functions.py:    from skimage.draw import line_aa, line, polygon, circle
pyCHX/v2/_futurepyCHX/chx_generic_functions.py:    from skimage.draw import line_aa, line, polygon, circle
pyCHX/v2/_futurepyCHX/chx_generic_functions.py:    from skimage.draw import polygon
pyCHX/v2/_futurepyCHX/chx_generic_functions.py:    from skimage.draw import line_aa, line, polygon, circle
pyCHX/v2/_futurepyCHX/chx_generic_functions.py:    from skimage.draw import line_aa, line, polygon, circle
pyCHX/v2/_futurepyCHX/chx_generic_functions.py:        from skimage.draw import circle
pyCHX/v2/_futurepyCHX/chx_libs.py:from skimage.draw import line_aa, line, polygon, ellipse, circle
pyCHX/v2/_futurepyCHX/chx_packages.py:from skimage.draw import line_aa, line, polygon
tankonst commented 2 years ago

I referenced a wrong issue number if the pull request. Should I just merge?

danielballan commented 2 years ago

Merged! Thank you.

Now we wait for the conda-forge bot to automatically open and merge a PR at https://github.com/conda-forge/pychx-feedstock/pulls. Then we can update the software environment on Jupyter.