NSLS-II / scientific-python-cookiecutter

a tutorial and 'cookiecutter' template for a scientific Python library
https://nsls-ii.github.io/scientific-python-cookiecutter/
BSD 3-Clause "New" or "Revised" License
116 stars 41 forks source link

BUG: isort repo is not consistent with latest poetry #121

Open sbillinge opened 1 year ago

sbillinge commented 1 year ago

it gives this stack dump when trying to install:

$ gcam "test precommit"
[INFO] Installing environment for https://github.com/pycqa/isort.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
An unexpected error has occurred: CalledProcessError: command: ('C:\\Users\\simon\\.cache\\pre-commit\\repobucbasvb\\py_env-python3\\Scripts\\python.EXE', '-mpip', 'install', '.')
return code: 1
stdout:
    Processing c:\users\simon\.cache\pre-commit\repobucbasvb
      Installing build dependencies: started
      Installing build dependencies: finished with status 'done'
      Getting requirements to build wheel: started
      Getting requirements to build wheel: finished with status 'done'
      Preparing metadata (pyproject.toml): started
      Preparing metadata (pyproject.toml): finished with status 'error'

stderr:
      error: subprocess-exited-with-error

      Preparing metadata (pyproject.toml) did not run successfully.
      exit code: 1

      [17 lines of output]
      Traceback (most recent call last):
        File "C:\Users\simon\.cache\pre-commit\repobucbasvb\py_env-python3\Lib\site-packages\pip\_vendor\pyproject_hooks\_in_process\_in_process.py", line 353, in <module>
          main()
        File "C:\Users\simon\.cache\pre-commit\repobucbasvb\py_env-python3\Lib\site-packages\pip\_vendor\pyproject_hooks\_in_process\_in_process.py", line 335, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "C:\Users\simon\.cache\pre-commit\repobucbasvb\py_env-python3\Lib\site-packages\pip\_vendor\pyproject_hooks\_in_process\_in_process.py", line 149, in prepare_metadata_for_build_wheel
          return hook(metadata_directory, config_settings)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "C:\Users\simon\AppData\Local\Temp\pip-build-env-n1eijkm0\overlay\Lib\site-packages\poetry\core\masonry\api.py", line 40, in prepare_metadata_for_build_wheel
          poetry = Factory().create_poetry(Path(".").resolve(), with_groups=False)
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "C:\Users\simon\AppData\Local\Temp\pip-build-env-n1eijkm0\overlay\Lib\site-packages\poetry\core\factory.py", line 57, in create_poetry
          raise RuntimeError("The Poetry configuration is invalid:\n" + message)
      RuntimeError: The Poetry configuration is invalid:
        - [extras.pipfile_deprecated_finder.2] 'pip-shims<=0.3.4' does not match '^[a-zA-Z-_.0-9]+$'

      [end of output]

      note: This error originates from a subprocess, and is likely not a problem with pip.
    error: metadata-generation-failed

    Encountered error while generating package metadata.

    See above for output.

    note: This is an issue with the package mentioned above, not pip.
    hint: See above for details.

Check the log at C:\Users\simon\.cache\pre-commit\pre-commit.log
mrakitin commented 1 year ago

Is it still a problem?

sbillinge commented 1 year ago

I can test it out shortly and let you know.

sbillinge commented 1 year ago

This seems to be resolved. I successfully created a package this time.

One small request....can it offer as options python 3.9, 3.10 and 3.11 rather than 3.8, 3.9 and 3.10?

Thanks so much,

S

On Fri, Jul 14, 2023 at 10:27 PM Max Rakitin @.***> wrote:

Is it still a problem?

— Reply to this email directly, view it on GitHub https://github.com/NSLS-II/scientific-python-cookiecutter/issues/121#issuecomment-1636397658, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAOWUK3JKDN53O6HOFISJ3XQGTSZANCNFSM6AAAAAAVLB3VP4 . You are receiving this because you authored the thread.Message ID: @.***>

-- Simon Billinge Professor, Columbia University