search

NSLS-II / wishlist

an issue tracker for the big picture
1 stars 0 forks source link

Refactor metadatastore to use event-model #112

Open ericdill opened 8 years ago

ericdill commented 8 years ago

Refactor the following libraries to use event-model

- [ ] metadatastore - [x] metadataclient

danielballan commented 8 years ago

MDS doesn't validate and IMO never should bother; it is headed for retirement. So does not need to be in this list I think.

ericdill commented 8 years ago

The "S" in "MDS" is supposed to be "store", right?

danielballan commented 8 years ago

Ah. Yes.

Also, MDC doesn't validate either, right? As long as the server does (it surely should) and bluesky does I don't see any reason why the client should blow more performance on validation.

Sent from Outlook Mobilehttps://aka.ms/qtex0l

On Wed, Mar 9, 2016 at 1:54 PM -0800, "Eric Dill" notifications@github.com<mailto:notifications@github.com> wrote:

The "S" in "MDS" is supposed to be "store", right?

— Reply to this email directly or view it on GitHubhttps://github.com/NSLS-II/wishlist/issues/112#issuecomment-194525873.

danielballan commented 8 years ago

Bluesky is done here: https://github.com/NSLS-II/bluesky/pull/272

ericdill commented 8 years ago

Also, MDC doesn't validate either, right?

I have no idea. I threw all the libraries that I knew of that used the event model up there and figured that someone would be suckered into answering that question for me :)

don't see any reason why the client should blow more performance on validation

Seems reasonable

ghost commented 8 years ago

Nope, MDC doesn't do any of the validation. It's all on the server side since we want to reflect schema to all clients without having to update client libraries once if we change the schema (yay, service layer). I'll take care of mds tonight if not tmrw am after my exam lol

ericdill commented 8 years ago

Bluesky is done here: NSLS-II/bluesky#272

Great. Updated the issue header

danielballan commented 8 years ago

@ericdill OK, cool. So then I would suggest removing MDC from the checklist. It's not done, but neither will it be needed.

ericdill commented 8 years ago

I wish github would show who clicked the 'x', because now I'm curious. I am leaving it up there, but struck through

ghost commented 8 years ago

I did

ghost commented 8 years ago

Metadataservice uses metadatastore(mds) in order to verify the documents. Both metadataclient and metadatastore enforce schema in an ODM/ORM-free fashion using the function definitions in DB_SINGLETON. We could add this as an extra safety net to mds but the API changes would be necessary in case of any changes to the schema. Thoughts? @tacaswell