NSLS-II / wishlist

an issue tracker for the big picture
1 stars 0 forks source link

Support modern pymongo and mongoengine #80

Closed danielballan closed 8 years ago

danielballan commented 8 years ago

Also, investigate whether there are any issues with pymongo 2.8 -> 2.9.

tacaswell commented 8 years ago

drop mongoengine is a better plan.

https://github.com/NSLS-II/metadatastore/pull/170 has changes required for migration.

danielballan commented 8 years ago

Yeah? What about connection management? On Mon, Nov 2, 2015 at 5:34 PM Thomas A Caswell notifications@github.com wrote:

drop mongoengine is a better plan.

NSLS-II/metadatastore#170 https://github.com/NSLS-II/metadatastore/pull/170 has changes required for migration.

— Reply to this email directly or view it on GitHub https://github.com/NSLS-II/wishlist/issues/80#issuecomment-153179115.

tacaswell commented 8 years ago

If we move to mds-as-an-object the connection can be managed on a per-instance basis and re-implementing that at a module level is likely less work than continuing to do a complete end-run around ME machinery.

attn @arkilic

ghost commented 8 years ago

The web service has to connect to tornado backed metadataservice therefore the only connection we need to worry about is the python requests one. @tacaswell, this is how it is currently handled, which I believe is what you suggested in your post: https://github.com/synchbot/metadataclient/blob/master/metadataclient/commands.py#L82