search

NSO-developer / nso-ansible-demo

Simple demo of the Ansible modules for NSO
Apache License 2.0
34 stars 24 forks source link

Enhancements to make demo setup easier #3

Closed kecorbin closed 6 years ago

kecorbin commented 6 years ago

Hi @cmoberg - here are a few of the things that I added to my fork to make life a bit easier. Feel free to merge if you think they are useful.

The only change that would have any material impact on the demo would be https://github.com/kecorbin/nso-ansible-demo/commit/ff6afa967a5e60b554bc021cb284a5aefb672582 this was an issue I encountered when executing against real devices instead of netsim. In the spirit of this demo, these keys should be inconsequential.

I also added a requirements in to address #2 for now, but as the target version is still moving, will need to be updated once things shake it.

HTH, Kevin

cmoberg commented 6 years ago

They all look really useful. May want to think about a more elegant solution for the json2yaml script over time (command line option perhaps), but this is a definite improvement for now.

cmoberg commented 6 years ago

And, if that wasn't clear: THANKS!