NSPManager / NSPanelManager

Sonoff NSPanel custom firmware for responsive and intuitive use
https://discord.gg/RwXvAH56fE
153 stars 11 forks source link

Weather and time functionality on Screensaver page #107

Closed cablesandcoffee closed 8 months ago

cablesandcoffee commented 11 months ago

There are a two enhancements that are in the same area so I created this one to keep track of the progress. Referenced issues: #105 #66

Goal of enhancement:

What I've done so far:

Some other thoughts

  1. Background/No background on screensaver page. Choice is made in NSPanelManager which results in a variable being set in Nextion screen on start of the screen. Logic of setting / removing background is solved by code prepared by Nextion screen.
  2. Weather/No Weather. This should be a function that has to be activated by the users. If not activated the weather items should be set to not visible. Might be a good solution to do the same as the background choice (another variable is set in the Nextion screen and the hiding/showing is taken care of from there?)
  3. Should not need to handle units, mm, celsius and so on. I'm thinking it should be known in the data that is received?
tpanajott commented 11 months ago

This is a very nice feature to have but I would say that it's not useful to add it to the current version. This is something that would be implemented with the new MQTTManager.

cablesandcoffee commented 11 months ago

Oh yes that's the plan of course. Maybe there's a way to create issues for different branches. I didn't think of that. 😊

tpanajott commented 8 months ago

As of latest beta in MQTT Manager rewrite, maybe this could be closed?

cablesandcoffee commented 8 months ago

Yes I agree, lets close it ! :)