search

NSPManager / NSPanelManager

Sonoff NSPanel custom firmware for responsive and intuitive use
https://nspanelmanager.com/
126 stars 10 forks source link

Fix Nextion v1.1 upload protocol #108

Closed jamesmulcahy closed 7 months ago

jamesmulcahy commented 7 months ago

I think commit 8ae97454 introduced a regression into the v1.1 upload protocol, and is mistakenly prepending a 1 to the baud rate.

Here are some logs, the first two runs are with the v1.2 protocol, the third is the same baud rate on v1.1, the fourth is the 38400 on v1.1. Both the v1.1 sessions have the 1 prepended.

C0:49:EF:D1:A7:28;DEBUG; NSPanel.cpp:723 f(._updateTFTOTA) Sending TFT upload command: whmi-wris 5452668,115200,1
C0:49:EF:D1:A7:28;DEBUG; NSPanel.cpp:723 f(._updateTFTOTA) Sending TFT upload command: whmi-wris 5452668,115200,1
C0:49:EF:D1:A7:28;DEBUG; NSPanel.cpp:723 f(._updateTFTOTA) Sending TFT upload command: whmi-wri 5452668,1115200,1
C0:49:EF:D1:A7:28;DEBUG; NSPanel.cpp:723 f(._updateTFTOTA) Sending TFT upload command: whmi-wri 5452668,138400,1
tpanajott commented 7 months ago

You are absolutely right. Nice catch and thanks for the PR. Will merge.