search

NSS-Day-Cohort-42 / ktk-truncheons-and-flagons

1 stars 1 forks source link

Gs second branch #22

Closed gavinschriver closed 4 years ago

gavinschriver commented 4 years ago
  1. git fetch --all
  2. git checkout branch gs-secondBranch
  3. Make sure there's a button on the page that console logs a custom event "startGameButtonClicked"
  4. make sure team and player forms are rendering at top
  5. see if the index.html test "view" divs look, um right? cool?
skratz17 commented 4 years ago

Yep there is def a button on the DOM that when you click it it sends the right event.

My only thing for this right now is - you're just setting the content target to container... we had kind of discussed creating a specific DOM node for each "step" in the game (i.e. one for start game button, one for team selects, one for score form), so maybe it would be good to add a div to index.html that specifically serves as a container for this button component? Instead of just putting it in the main container?

skratz17 commented 4 years ago

Okay looks great to me 👍