search

NSS-Day-Cohort-49 / react-nutshell-state-slingers

react-nutshell-state-slingers created by GitHub Classroom
0 stars 1 forks source link

Mat friends #18

Closed mtrevin93 closed 3 years ago

mtrevin93 commented 3 years ago

Changes Made

  1. Added files FriendsProvider, FriendList, FriendCard, FriendForm to friend directory.
  2. Modified file ApplicationViews to include friend route. ​

    Steps to Review

  3. Checkout this branch locally. 
    git fetch --all
git checkout mat-friends
  4. Open a new Terminal tab (⌘T) and navigate to the server directory.
  5. Test app functionality.

    Navigate to friends page. It should display friends of logged in user. When a user's full name (whitespace and case should not matter) or username is entered, a friend relationship should be created and immediately appear. A friend relationship that already exists or a name that does not find a match should generate an alert When a user clicks the delete button, the related relationship should be deleted and the friend should be removed from the list

  6. View code file.

    Confirm file modifications are present as indicated above. Confirm no unused code or extraneous comments exist.

luzm321 commented 3 years ago

Looks awesome! There is a small bug that displays a "Cannot read property 'id' of undefined" error when a user types in a invalid name/username after the alert window pops up. BUG FIXED! :D Otherwise, the rest of the functionalities are working, great job! 💯

hcrudge commented 3 years ago

Looks good. Bugs squashed!