search

NSSAC / CINES

CINES project repository
Other
1 stars 0 forks source link

Explain the expected output #254

Closed dmachi closed 2 years ago

dmachi commented 3 years ago

In the description of a job definition, explain what the output will be (job output, file output and type). This should show up on at least the job submission form, but probably also in the job definition list.

murli1201 commented 3 years ago

Hi Dustin, Is it okay if we show output data as shown in the below screenshot?

Screenshot (130)

dmachi commented 3 years ago

I don’t think we should show “output file” like that, as that is really its internal name. The name that will actually get used is what is shown by the user. Instead, I think this should be done as an additional sentence at the end of the description. It can be one of:

  1. For file output data only: “This task outputs a file of type in your chosen location”

  2. For Job output only: This task outputs data attached to the job. Click to see the schema of the output.
    For this one, you can make a popup show the output_schema in a popup.

  3. For both: This task outputs a file of type in our chosen location and also generates output attached to the job. Click to see the schema of the job attached output. Similar to #2, clicking here can show a popup with the output_schema.

On Sep 23, 2021, at 9:21 AM, murli1201 @.***> wrote:

Hi Dustin, Is it okay if we show output data as shown in the below screenshot?

https://user-images.githubusercontent.com/54397265/134514414-b9a9a530-1624-487a-82d0-0a3f182e7373.png — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/NSSAC/CINES/issues/254#issuecomment-925811689, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABOQ3RXCITLMWOO3MSOXETUDMSXJANCNFSM5EOJAAZQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

murli1201 commented 3 years ago

Okay, I get it. I will make changes and then show you in the next meeting. For job definition listing, do you want this to be in a similar way too?

dmachi commented 3 years ago

Yes, please.

On Sep 23, 2021, at 9:51 AM, murli1201 @.***> wrote:

Okay, I get it. I will make changes and then show you in the next meeting. For job definition listing, do you want this to be in a similar way too?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/NSSAC/CINES/issues/254#issuecomment-925836021, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABOQ3QQPG7EOBREDOW22B3UDMWHPANCNFSM5EOJAAZQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

dmachi commented 2 years ago

Ok, I understand why only the first N items in the job definition list have this information. The actual bug is that none of them should have this information. Lets change this request to ONLY show that extra detailed information when you view a single job defintion (i.e., leave it off of the list view).

murli1201 commented 2 years ago

Okay, I will make these changes and commit them.