search

NSWSESMembers / Lighthouse

Beacon Tools and UI Improvements
Other
15 stars 15 forks source link

Add lighthouse layers to the tasking map #111

Closed tmyroadctfig closed 7 years ago

tmyroadctfig commented 7 years ago

I want to add the team positions to the tasking screen map, so this is the first step: starting to tease out some of the common code.

I did a quick smoke test of most things and they seemed to be working still.

tmyroadctfig commented 7 years ago

The review isn't ideal... this mostly turned into a cut & paste exercise. The biggest change is that I wrapped up the content side code into a class. I tried to do the same for the inject side, but it was a far larger task, so I left it for now.

OSPFNeighbour commented 7 years ago

Are you finally going to show tasked as well as onroute/site/off :P our flood desk would love to see tasked.

tmyroadctfig commented 7 years ago

I'm not sure how that would work. The goal here is for this to be a poor-man's AVL substitute, i.e. to give ops some rough ideal of where the team is/is-going, or just-left-from. If you mark the team down to every job it's tasked against, it might be a bit unclear where they are.

OSPFNeighbour commented 7 years ago

But when you go to task a job, knowing which jobs are tasked to who would be helpful.

On 23 Sep. 2017 2:50 pm, "Luke Quinane" notifications@github.com wrote:

I'm not sure how that would work. The goal here is for this to be a poor-man's AVL substitute, i.e. to give ops some rough ideal of where the team is/is-going, or just-left-from. If you mark the team down to every job it's tasked against, it might be a bit unclear where they are.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/NSWSESMembers/Lighthouse/pull/111#issuecomment-331610625, or mute the thread https://github.com/notifications/unsubscribe-auth/AFh9NjfMsjfId56HBPhBHfpkXvrTBwK3ks5slI4ugaJpZM4Pdvnb .

OSPFNeighbour commented 7 years ago

Happy to land but it conflicts now. any chance you can refactor?