Closed SegFaulty closed 2 years ago
So this is a lot more than just fixing the search terms not showing up. You got everything from bug fixes, to styling changes, to game-play changes. That's not necessarily bad but i would like to check things over more since it is a good amount of stuff. Still i appreciate it.
So this is a lot more than just fixing the search terms not showing up. You got everything from bug fixes, to styling changes, to game-play changes. That's not necessarily bad but i would like to check things over more since it is a good amount of stuff. Still i appreciate it.
sorry sorry ... that was not my intention it's because i'm not familiar with github and this is my very first pull request i expected only the first commit to be in the pull request because i opened the pull request right after the first commit, i still have to learn how this works
my intention was to offer the most promising changes as a pull request, so you can choose which ones to include, apparently it doesn't work that way ... sorry again
a few words first I'm hooked on this scenario and I had some ideas to take it further or make it smoother but ... I am new to factorio modding, new to lua and inexperienced in github procedures but maybe I am a senior developer in other areas ... so if you are interested in me contributing to Transportorio, I would appreciate if you tell me if I am doing something wrong, mishandling in all aspects of modding, Lua, Github, etc.
i try to make thematic commits in my fork maybe you can cherry pick (?) what you find useful I am open for suggestions how to offer it most useful
closed ... wrong process
mhm i learned now, you have already a refacturing of the menu in progress, so maybe it makes not so much sense to try to push my changes back to your version :-/
search history is used when open menu, but search string not shown, the user can see what the list is filtered by