search

NSoiffer / MathCAT

MathCAT: Math Capable Assistive Technology for generating speech, braille, and navigation.
MIT License
61 stars 35 forks source link

Feature request: Enable logs #278

Closed EL-Dol closed 1 month ago

EL-Dol commented 2 months ago

Feature request: Enable logs

Hi, I would request a feature to enable logs for easy debugging. Have created a simplified version for debugging on Android at version bump to 0.6.3 and it can be found attached.

Files

MathCAT-4a6cf12-Added a feature to enable logs on Android.patch MathCATForC_enable-logs.patch

NSoiffer commented 2 months ago

The changes seem reasonable, although I would think logging should be restricted to just the debug build.

On my windows machine, patch complains about line endings. Can you submit the changes as a PR? That would be safer.

Thanks.

EL-Dol commented 1 month ago

Yes, it would be nice if it was automatically enabled for debug, a bit unsure how to do that tough. And I would love to upload all the code do a pull request, but I'm getting a permission denied when trying.

NSoiffer commented 1 month ago

Apologies if you already know this...

You shouldn't have a problem if you created a fork and you uploaded to your fork. So I'm guessing you just cloned MathCAT. In that case, you should be able to create a branch and do a pull request from there. I just looked and noticed I didn't have any protections on who could do what to branches. I just added a rule that limits who can push to main.

If you are still having problems, can you tell me specifically what you are doing?

EL-Dol commented 1 month ago

Hi, thanks for the info. Haven't worked against public GitHub projects before, so the procedure was a bit different than what I'm used to. There is now a merge request for MathCat about "Enable Logs" for Android.

NSoiffer commented 1 month ago

Merged.