search

NSoiffer / MathCATForPython

A Python Interface and NVDA plugin to MathCAT
MIT License
6 stars 6 forks source link

Add language names to list box #41

Closed ways2read closed 1 year ago

ways2read commented 1 year ago

Add language names to list box based on the language codes derived from the folder names.

NSoiffer commented 1 year ago

I think it is better to just define the languages as list directly. I've linked a file with the definition in it to make your life easier.

I don't know github well enough to know how to modify your PR myself, so I'm afraid I pushing this back to you... new language dictionary

ways2read commented 1 year ago

Please check if you are happy to merge this now.

NSoiffer commented 1 year ago

Looks good. I probably would have just made the table global rather than have a function that returns it, but what you have is fine.

NSoiffer commented 1 year ago

I merged it in. Your code is working, but MathCAT seems to be stuck on English in NVDA (changing languages works fine stand-alone). We might need to add a "User Preference" option where the language used matches the language NVDA is set to use (we'll make up a code like "default" that can't match anything but has a nice display "User Preference (default)" . Don't make a change until I figure this out though. I'm off to get some exercise while the rain (and wind) have stopped, so you probably won't hear from me until tomorrow your time.

Neil

On Wed, Dec 28, 2022 at 12:39 PM Richard Orme @.***> wrote:

Please check if you are happy to merge this now.

— Reply to this email directly, view it on GitHub https://github.com/NSoiffer/MathCATForPython/pull/41#issuecomment-1366904504, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALZM3FMLNINUULBCNXDZYTWPSQQDANCNFSM6AAAAAATKTSBNI . You are receiving this because you commented.Message ID: @.***>