search

NSoiffer / MathCATForPython

A Python Interface and NVDA plugin to MathCAT
MIT License
6 stars 6 forks source link

Translation system error #72

Open seanbudd opened 5 months ago

seanbudd commented 5 months ago

There is an error preventing translations of MathCAT

Failure during addon translation update: MathCAT
+ addonPath=/home/nvdal10n/mr/addons/MathCAT
+ cd /home/nvdal10n/mr/addons/MathCAT
+ '[' 0 -ne 0 ']'
+ mr addon2svn
mr addon2svn: /home/nvdal10n/mr/addons/MathCAT
Running addon2svn for MathCAT
Already on 'stable'
Your branch is up to date with 'origin/stable'.
HEAD is now at 70f2575 Merge branch 'stable' of https://github.com/nvdaaddons/mathCATForPython into stable
scons: Reading SConscript files ...
ModuleNotFoundError: No module named 'markdown':
  File "/home/nvdal10n/mr/addons/MathCAT/sconstruct", line 12:
    import markdown
mr addon2svn: command failed
NSoiffer commented 5 months ago

It builds ok on github and my desktop computer. The github action has:

        pip install scons markdown
        sudo apt update
        sudo apt install gettext

Looking further, this seems to be happening because sconstruct has

import markdown

This was moved by someone other than me from inside def md2html to the top level to make the linter happy. The original usage came code that I got from somewhere else (probably from @nvdaes).

Is importing markdown in option in the main build? Should I see what happens if I remove it or move it back to md2html?

nvdaes commented 5 months ago

@NSoiffer , I don't have issues in my add-ons with scons, so I don't know. You may look at:

https://github.com/nvdaes/clipContentsDesigner

Or any other add-on from my GitHub account.

NSoiffer commented 5 months ago

Your clipContentsDesigner link has

uses: nvdaes/nvdaAddonWorkflows/.github/workflows/automaticRelease.yaml@main

and that uses pip install Markdown. There is a difference in case. I don't know if that matters.

@seanbudd: It seems that including that install is what is needed. I don't think this is a MathCAT issue.