Example spaceline looks broken

shaunsingh commented 2 years ago

Hi, the example spaceline config doesn't look like the README screenshot. I have Nerd Fonts installed and used, and I'm using alacritty + neovim 0.5.

shaunsingh commented 2 years ago

Evilline looks fine, so I think my neovim config/setup is fine as well

NTBBloodbath commented 2 years ago

Hey, so I think the ones in the README showcase are modified versions of spaceline. Maybe we should refact our example one to match one of those :thinking:

shaunsingh commented 2 years ago

That would be nice! I was looking at this one:

Searching around a bit, looks like the code is here: https://github.com/Th3Whit3Wolf/dots/blob/main/private_dot_config/private_nvim/private_lua/private_plugins/statusline/private_init.lua

I also found this: https://github.com/Groctel/dotfiles/blob/main/files-common/.config/nvim/lua/neonline.lua, which (according to the screenshots in the dotfiles repo) looks like this:

I think the first one looks better, but the code is a mess. Second one is probably easier to adapt between themes and should be fairly straightforward to implement

NTBBloodbath commented 2 years ago

Thank you for looking them!

So what do you recommend, should we add both? We would need to do a small refactor in the first one to make the code beauty but that's pretty simple ig, and the second one is very beauty too :eyes:

shaunsingh commented 2 years ago

I'm fine with adding both. Looks like the author of the second one recently adjusted it to use your fork as well! First one looks fine, other than the colors and providers which should both be an easy fix

NTBBloodbath commented 2 years ago

Right, so I just added neonline. The only theme left would be spaceline, but this one will require a ton of refactoring so it's gonna take longer haha

hackel commented 2 years ago

FYI I tried to enable neonline, and got this:

^I...ite/pack/packer/start/galaxyline.nvim/lua/galaxyline.lua:26: in function <...ite/pack/packer/start/galaxyline.nvim/lua/galaxyline.lua:25>
E15: Invalid expression: luaeval('require("galaxyline").component_decorator')("DiagnosticError")                                                                                                                                                                                                                              
Does not found this component: FileEncode
Does not found this component: FileFormat
Does not found this component: DiffAdd
Does not found this component: DiffModified
Does not found this component: RainbowRed
Does not found this component: ViMode
Does not found this component: PerCent
...start/galaxyline.nvim/lua/galaxyline/themes/neonline.lua:183: attempt to call field 'get_count' (a nil value)
stack traceback:
^I...start/galaxyline.nvim/lua/galaxyline/themes/neonline.lua:183: in function 'cmd'
^I...ite/pack/packer/start/galaxyline.nvim/lua/galaxyline.lua:26: in function <...ite/pack/packer/start/galaxyline.nvim/lua/galaxyline.lua:25> function: builtin#18 ...start/galaxyline.nvim/lua/galaxyline/themes/neonline.lua:183: attempt to call field 'get_count' (a nil value)
stack traceback:
^I...start/galaxyline.nvim/lua/galaxyline/themes/neonline.lua:183: in function 'cmd'
^I...ite/pack/packer/start/galaxyline.nvim/lua/galaxyline.lua:26: in function <...ite/pack/packer/start/galaxyline.nvim/lua/galaxyline.lua:25> function: builtin#18 ...start/galaxyline.nvim/lua/galaxyline/themes/neonline.lua:183: attempt to call field 'get_count' (a nil value)
stack traceback:
^I...start/galaxyline.nvim/lua/galaxyline/themes/neonline.lua:183: in function 'cmd'

NTBBloodbath / galaxyline.nvim

Example spaceline looks broken #2