search

NTBBloodbath / galaxyline.nvim

neovim statusline plugin written in lua
MIT License
163 stars 16 forks source link

Update for vim.diagnostic #22

Closed mattleong closed 2 years ago

mattleong commented 2 years ago

Updates providers/diagnostics.lua with updated vim.diagnostic api to get diagnostic counts.

mattleong commented 2 years ago

Let me know if you need anything from me to get this merged!

mattleong commented 2 years ago

Tbh I like that one better too. Feel free to close :)

mrdgo commented 2 years ago

The reference I posted was a PR to the original repo by glepnir. IMO you could also adjust your implementation to match the linked one.

At least, I don't know whether you can apply a PR from a different repo. It might be enough to refer to dsych in the commit message.

mattleong commented 2 years ago

Ah gotcha. I was on mobile but I see that now.

I can update the PR and leave a comment.

mattleong commented 2 years ago

@mrdgo PR updated 👍

NTBBloodbath commented 2 years ago

Hey, I'm really sorry for the HUGE delay on my response. Work and other projects have been taking my whole time lately!

Thank you so much for doing this, I really appreciate the PR changes and will merge this asap. Sorry for the wait! :)

NTBBloodbath commented 2 years ago

updating the README.md to require nvim 0.6 also seems very important to me.

Agreed, if you can please change this before merging I'll be very thankful :)

mattleong commented 2 years ago

Agreed, if you can please change this before merging I'll be very thankful :)

Done! 😄

NTBBloodbath commented 2 years ago

Great, thank you so much! :)