Closed matthew-z closed 4 years ago
somehow the CI failed because it failed to install tensorflow==2.0.0
instead of using 2.0.0
, choose one version from: 2.0.0a0
, 2.0.0b0
, 2.0.0b1
2.0.0
official version has been released, but the pip used in trusty is too old to install it. I will add commands to upgrade pip
in the .travis.yml
and have a try again.
Merging #791 into master will increase coverage by
0.01%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #791 +/- ##
==========================================
+ Coverage 96.3% 96.31% +0.01%
==========================================
Files 83 83
Lines 2541 2549 +8
==========================================
+ Hits 2447 2455 +8
Misses 94 94
Impacted Files | Coverage Δ | |
---|---|---|
matchzoo/models/drmm.py | 100% <ø> (ø) |
:arrow_up: |
matchzoo/layers/matching_layer.py | 91.8% <100%> (+0.13%) |
:arrow_up: |
matchzoo/losses/rank_cross_entropy_loss.py | 100% <100%> (ø) |
:arrow_up: |
matchzoo/losses/rank_hinge_loss.py | 90.47% <100%> (+1.58%) |
:arrow_up: |
matchzoo/models/conv_knrm.py | 97.82% <100%> (-0.05%) |
:arrow_down: |
matchzoo/models/drmmtks.py | 100% <100%> (ø) |
:arrow_up: |
matchzoo/models/mvlstm.py | 100% <100%> (ø) |
:arrow_up: |
matchzoo/models/duet.py | 100% <100%> (ø) |
:arrow_up: |
matchzoo/layers/dynamic_pooling_layer.py | 91.17% <100%> (ø) |
:arrow_up: |
matchzoo/models/knrm.py | 100% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 2c46ad4...2f43f7b. Read the comment docs.
OK, CI passed
Wait, this is not on dev branch... You are supposed to make changes on branch 2.2-dev
. Could you please do so?
I guess after this PR is merged, we will release a 2.3
version.
OK I will rebase to dev-2.2 and open a new PR
keras.losses.Loss
keras.backend.tf
withtf
(K.tf does not exist anymore as keras is going to be synced with tf.keras and drop multi-backend)We may consider to replace
keras
withtf.keras
in the future.fix #789