NTMC-Community / MatchZoo

Facilitating the design, comparison and sharing of deep text matching models.
Apache License 2.0
3.82k stars 898 forks source link

add support for keras 2.3 #791

Closed matthew-z closed 4 years ago

matthew-z commented 4 years ago

We may consider to replace keras with tf.keras in the future.

fix #789

matthew-z commented 4 years ago

somehow the CI failed because it failed to install tensorflow==2.0.0

uduse commented 4 years ago

instead of using 2.0.0, choose one version from: 2.0.0a0, 2.0.0b0, 2.0.0b1

matthew-z commented 4 years ago

2.0.0 official version has been released, but the pip used in trusty is too old to install it. I will add commands to upgrade pip in the .travis.yml and have a try again.

codecov-io commented 4 years ago

Codecov Report

Merging #791 into master will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #791      +/-   ##
==========================================
+ Coverage    96.3%   96.31%   +0.01%     
==========================================
  Files          83       83              
  Lines        2541     2549       +8     
==========================================
+ Hits         2447     2455       +8     
  Misses         94       94
Impacted Files Coverage Δ
matchzoo/models/drmm.py 100% <ø> (ø) :arrow_up:
matchzoo/layers/matching_layer.py 91.8% <100%> (+0.13%) :arrow_up:
matchzoo/losses/rank_cross_entropy_loss.py 100% <100%> (ø) :arrow_up:
matchzoo/losses/rank_hinge_loss.py 90.47% <100%> (+1.58%) :arrow_up:
matchzoo/models/conv_knrm.py 97.82% <100%> (-0.05%) :arrow_down:
matchzoo/models/drmmtks.py 100% <100%> (ø) :arrow_up:
matchzoo/models/mvlstm.py 100% <100%> (ø) :arrow_up:
matchzoo/models/duet.py 100% <100%> (ø) :arrow_up:
matchzoo/layers/dynamic_pooling_layer.py 91.17% <100%> (ø) :arrow_up:
matchzoo/models/knrm.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2c46ad4...2f43f7b. Read the comment docs.

matthew-z commented 4 years ago

OK, CI passed

uduse commented 4 years ago

Wait, this is not on dev branch... You are supposed to make changes on branch 2.2-dev. Could you please do so?

uduse commented 4 years ago

I guess after this PR is merged, we will release a 2.3 version.

matthew-z commented 4 years ago

OK I will rebase to dev-2.2 and open a new PR