NTNU-IndEcol / BuildME

6 stars 1 forks source link

Amount of wall material is not influenced by window size #26

Closed kamilakrych closed 3 years ago

kamilakrych commented 3 years ago

As Tazrin has recently discovered, changing the window size doesn't influence the amount of material in walls. This is clearly wrong, as the bigger windows we have, the less "wall material" we should be left with (bricks, insulation, wood - whatever constitutes the walls). Currently, the only material type that is influenced by the change in window size is the amount of glass.

This bug is caused by the fact that the wall surface is calculated as "full" wall and fenestration area is not subtracted from it. I've been working on the fix and I think I have it!

kamilakrych commented 3 years ago

@nheeren This is the bug I recently told you about. I managed to fix it, and tried to upload the fix as a new branch. I'm doing this for the first time, so if I'm not mistaken, now it's just enough to merge my branch with the master one 😉