NTNU-IndEcol / BuildME

6 stars 1 forks source link

Compatibility with Windows and macOS #32

Open nheeren opened 2 years ago

nheeren commented 2 years ago

It seems like some changes that @kamilitsa or Andrea did earlier made BuildME incompatible with macOS. @aishuiyer1 did you also have issues running BuildME on your Mac?

The issue is that functions need to be called differently on nix systems.

I am trying to figure something out that is platform-agnostic. I will be pushing an updated version soon and update here. It would be great if @kamilitsa or @shnkn could confirm if all is well on Windows next time they run BuildME.

nheeren commented 2 years ago

Added the absolute path to the execution call. This should work now on both platforms now.

https://github.com/nheeren/BuildME/blob/dddeff73e0c909b89096ae3eec71d53eb6678d46/BuildME/energy.py#L111

https://github.com/nheeren/BuildME/blob/dddeff73e0c909b89096ae3eec71d53eb6678d46/BuildME/energy.py#L146-L147

Please feel free to close the issue if it works @kamilitsa @shnkn