search

NTNU-IndEcol / BuildME

6 stars 1 forks source link

Floor surfaces omitted #35

Closed nheeren closed 2 years ago

nheeren commented 2 years ago

Due to the changes in #16, the contact surface of floors was renamed from Ground to GroundSlabPreprocessorAverage. The latter is not considered in idf.get_surfaces().

nheeren commented 2 years ago

OK. Hope this is fixed. I added 'GroundSlabPreprocessorAverage' to idf.get_surfaces().

https://github.com/nheeren/BuildME/blob/cec99f1e25ea503425caf73317d4d16a33065cf6/BuildME/idf.py#L139-L142

@kamilitsa: Would be good to have a quick word from you why this was missed previously, in order not to overlook anything. I am sure you tested the new ground temperature implementation...

kamilakrych commented 2 years ago

I'm quite surprised by this, good that you caught the bug. I can see that GroundBasementPreprocessorAverageWall was added, but for some reason GroundSlabPreprocessorAverage was not. Now I don't remember anymore how it happened... Anyway, thanks, and sorry!

nheeren commented 2 years ago

Thanks @kamilitsa. It is odd. There was another fix I had to do (see line 560 in 3973259) in order to run it. So it seems that some of your local changes may not have been part of the pull request.