search

NTNU-IndEcol / BuildME

6 stars 1 forks source link

replace_mmv.xlsx does not exist #45

Open nheeren opened 2 years ago

nheeren commented 2 years ago

https://github.com/nheeren/BuildME/blob/5fb5bf0b18f777c3dc73b54c33cb7866e4114576/BuildME/simulate.py#L159

@kamilitsa Thanks for the latest commit. Why does it say "revert" btw?

The script now expects the file ./data/replace_mmv.xlsx to be present and therefore crashes on my computer. Either we provide an initial file or we also have a routine that makes sure the file is created on first run.

kamilakrych commented 2 years ago

Should be fixed now. I checked and all runs as it should. Even if there is no MMV variant on the first run, an empty replace_mmv.xlsx is created anyway.

kamilakrych commented 2 years ago

I updated this in a new commit in my branch: 69a3e99a2f6717a904c84b47a2ba5b118764fba5. Previously, I said 'an empty replace_mmv.xlsx is created anyway' but now it seems unprofessional to me 😛

So I updated the code - now the empty file is NOT created. It was counterintuitive that the pre.create_mmv_variants() had to be run even when MMV variants were not chosen in the building combinations...

nheeren commented 2 years ago

Hmm. So far I am cherry-picking your code snippets. Do you think it would make sense to create a pull request for this?