Closed kamilakrych closed 8 months ago
Hi @kamilitsa!
I haven't tried to run the tutorial yet, however it seems very interesting; I especially liked the part on apply_obj_name_change()
. As far as I know, the use of the 'replaceme' strings wasn't explained anywhere (yet).
I'll try to run it when I have some time!
Thanks for the quick reply :) Just one more thing, I have slightly improved the calculate_materials() function. The tutorial won't work unless you update it as well - see this commit
Thank you so much @kamilitsa. A lot of students will love you for this ;) @CBreton026, you were mentioning at some point that you were making some notes on using BuiildME, so maybe we should discuss if your notes should integrate with tutorial notebooks.
Good idea! I'll keep it in mind.
Hi @kamilitsa, I just thought of a potential issue - what climate files / paths are used for the tutorial? Since the Meteonorm files were removed from the repo, anyone new to BuildME may have trouble running the tutorial "out of the box". It's a problem I also encountered when starting, as well as when running tests.
My suggestion would be that we add the EnergyPlus TMY3 climate files to the repo (or at least one of them) so that it's easy for anyone to start the tutorial.
The notebook is great ! Thank you!
Here are a few improvements I would suggest:
Selection of archetypes
: Explain the files that need to be present (1A.epw, SFH.idf, etc.) and that they come with BuildME or need to be downloaded in case of the climate files. We can refer to https://github.com/nheeren/BuildME/blob/master/docs/setup.mddebug_combinations
in a way that a few combinations are created. The current variable will yield only one single combination.Concerning the open questions:
Will you do the next iteration, @kamilitsa ?
I agree, it works perfectly.
Honestly, I still do not know what the divide_by_area, disaggregate_scenario_str, and weighing_climate_region do detailly, so I agree with Niko that these might be a bit too complex for beginners.
So maybe for the material intensity calculations, giving more information about the included building components would be good (i.e., window frame, external wall, internal partitions, roof, floor, door, shading device? etc. ).
Apart from that I do not have any other suggestions :)
Thank you for all the insightful suggestions! I have implemented all of them, you can have a look in my branch.
Just one follow-up comment: I have added a 'dummy' weather file, as suggested by Charles. This way the user can perform the simulations even if no weather files are created. However, to use the full functionality of the framework, the user would need to add the weather files. Maybe it should be mentioned in the setup file?
tutorial finished, added mention of weather files in the setup file
As requested by Niko, I have created a simple tutorial walking (available in my branch here) through the main steps of BuildME. Could you please have a look at it and give some feedback? E.g. does the code work for you, are the explanations clear? There is one part missing at the very end, it's either to be deleted altogether or to be extended by some comments explaining the points I mention there.
Charles, if you want to have a look at it, your feedback is also more than welcome! I cannot mention/tag you though :)